[PSA] Major Animal Bugs & Issues

CandyCreeper42 · Nov 27, 2017

Stryder87 said: ↑

I have a hard enough time trying to figure out why crops disappear when I have scarecrows out and there's been no rain!
Click to expand...

About that. Just ironing out the obvious and probably already thought of (sorry if it has been) before I go into argh bug panic mode and suggest you make a thread for that:
Do you have enough scarecrows? Stick your farm layout into the Stardew Valley Farm Planner and check everything's covered. If it is (which it probably is) then report back because I've no idea what's going on then.

Stryder87 · Nov 27, 2017

CandyCreeper42 said: ↑

About that. Just ironing out the obvious and probably already thought of (sorry if it has been) before I go into argh bug panic mode and suggest you make a thread for that:
Do you have enough scarecrows? Stick your farm layout into the Stardew Valley Farm Planner and check everything's covered. If it is (which it probably is) then report back because I've no idea what's going on then.
Click to expand...

I have overlap on all my scarecrows, so the coverage is good. It doesn't happen very often, it just throws off my pretty layouts and harvesting schedule when you have one that is two days behind all the rest for harvesting. I can get really really... ... tight... about that stuff. haha
I usually just whack the scarecrow that covers the crop that went missing then put it back down (same place). It never happens again in that zone. It just seems like a scarecrow will sometimes stop working until you place it again.
Who knows. Not a panic, it just skews my graph!

rkagerer · Feb 22, 2018

Is the staying up past 6pm thing still bugged? Any fix on the horizon?

Jurk0wski · Feb 25, 2018

rkagerer said: ↑

Is the staying up past 6pm thing still bugged? Any fix on the horizon?
Click to expand...

Last I checked, yes. There's been no patches for the last several months. Here's hoping it's fixed in the multiplayer update that's coming.

rkagerer · Mar 2, 2018

Jurk0wski said: ↑
I was browsing the wiki for random info for a future playthrough, since I hadn't played in a while, and I ran across that the decreasing mood bug still exists, and I found this thread while googling the issue. I'm bored, so here's my crack at the currently exisiting bug. Assuming the code linked in the first post is how it currently is...
Code:
if ((environment.IsOutdoors && timeOfDay > 1900) || (!environment.IsOutdoors && this.happiness > 150) || (environment.isOutdoors && Game1.isRaining) || (environment.isOutdoors && Game1.currentSeason.Equals("winter")))
{
       this.happiness = (byte)Math.Min(255, Math.Max(0, (int)(this.happiness - ((environment.numberOfObjectsWithName("Heater") > 0 && Game1.currentSeason.Equals("winter")) ? (-this.happinessDrain) : this.happinessDrain))));
}
The main issue is just that there's not enough checks. I assume what this snippet of code is intended to do is check if an animal is outside past a certain time, indoors before a certain time, outside while it's raining, or outside while it's winter, and if so, reduce it's mood by a set amount every 10 minutes until the animal's situation is fixed. It also is intended to increase an animal's mood while indoors in winter if it has a heater before the set time it'd fall asleep. So it seems the main issue is that the initial indoors happiness check does not check to see if it's below a certain time.
Code:
(!environment.IsOutdoors && this.happiness > 150)
This can be fixed by adding a time check for before 6PM:
Code:
(!environment.IsOutdoors && this.happiness > 150 && timeOfDay < 1800)
Additionally, it seems to me that the heater check does not check to see if the animal is indoors, so it should also be checked.
Code:
(environment.numberOfObjectsWithName("Heater") > 0 && Game1.currentSeason.Equals("winter"))
Should actually be:
Code:
(!environment.IsOutdoors && environment.numberOfObjectsWithName("Heater") > 0 && Game1.currentSeason.Equals("winter"))
I can't actually remember if you can even place heaters outside of the coop/barn, but if you can, or if you somehow end up with a different object named "Heater" outdoors, it prevents the issue.

Finally, there's no check for animals that are indoors at any happiness level, not just above 150, with a heater in winter so this code:
Code:
(environment.isOutdoors && Game1.currentSeason.Equals("winter"))
should be adjusted to accept indoors animals before 6PM:
Code:
((environment.isOutdoors || (!environment.isOutdoors && timeOfDay < 1800)) && Game1.currentSeason.Equals("winter"))
The final code would look like this:
Code:
if ((environment.IsOutdoors && timeOfDay > 1900) || (!environment.IsOutdoors && this.happiness > 150 && timeOfDay < 1800) || (environment.isOutdoors && Game1.isRaining) || ((environment.isOutdoors || (!environment.isOutdoors && timeOfDay < 1800)) && Game1.currentSeason.Equals("winter")))
{
       this.happiness = (byte)Math.Min(255, Math.Max(0, (int)(this.happiness - ((!environment.IsOutdoors && environment.numberOfObjectsWithName("Heater") > 0 && Game1.currentSeason.Equals("winter")) ? (-this.happinessDrain) : this.happinessDrain))));
}
The end result is as such: If the animal is outdoors and either the time is past 7PM or it is raining, or if the animal is indoors before 6PM in any season and has 150 or more happiness, or it is winter and the animal is outdoors or is indoors before 6PM, the animal's mood will shift. If, then, the animal is indoors with a heater in winter, the animal's mood will negatively reduce, resulting in a positive gain (since two negatives make a positive), never going above 255. Otherwise, if the above conditions were met, but either the animal is not indoors with a heater and it's winter, the animal's mood reduces over time, eventually reaching 0, unless they are indoors, in which case it will only drop to at least 150 (the actual amount may be lower depending on how much was drained in the last check). This also prevents animals from gaining mood with a heater indoors past 6PM, since animals would no longer qualify for the if statement, which makes sense, since they should be asleep or going to sleep soon. Animals would still be getting a ton of happiness over time in winter with a heater, but that could be seen as a feature rather than a bug for most people, but even that can be fixed with more checks in place.

Additionally, if you wanted to outright prevent mood gain from the heater in winter, but still wanted there to be repercussions for not having a heater, all you need to do is change
Code:
(-this.happinessDrain)
into:
Code:
0
Brought to you by a bored person at 5 AM.
Click to expand...
Until this gets fixed officially, has anyone thought about taking Jurk0wski's work and patching the EXE ourselves?

ShneekeyTheLost · Mar 3, 2018

rkagerer said: ↑

Until this gets fixed officially, has anyone thought about taking Jurk0wski's work and patching the EXE ourselves?
Click to expand...

Editing the executable is a dangerous prospective, however fortunately it is also unnecessary. There's a mod called Mood Guard that fixes precisely this.

Log in or Sign up

[PSA] Major Animal Bugs & Issues

CandyCreeper42 Void-Bound Voyager

Stryder87 Giant Laser Beams

rkagerer Intergalactic Tourist

Jurk0wski Orbital Explorer

rkagerer Intergalactic Tourist

ShneekeyTheLost Master Astronaut

Share This Page

Log in or Sign up

[PSA] Major Animal Bugs & Issues

CandyCreeper42 Void-Bound Voyager

Stryder87 Giant Laser Beams

rkagerer Intergalactic Tourist

Jurk0wski Orbital Explorer

rkagerer Intergalactic Tourist

ShneekeyTheLost Master Astronaut

Share This Page

Useful Searches